Skip to content

feat(ci): elaboration errors may fall, never rise - #2430

Merged
gHashTag merged 1 commit into
masterfrom
fix/elab-round4
Aug 22, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/elab-round4

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Refs #2325. Holds the 573 -> 186 win per module; fails naming the module and both numbers. Negative control done twice — the first was a no-op that silently passed.

🤖 Generated with Claude Code

Three emitter classes took the 32-module fpga set from 573 iverilog
elaboration errors to 186 in one evening, and nothing held that line: the
conformance job executes two modules and the other thirty are only
yosys-linted, which is how the class grew unseen in the first place.

check_elab_ratchet.py records the count per module and fails when any
module gains errors, naming the module and both numbers. It does not
demand zero -- the remainder is two named design decisions (string
comparison in hardware; unsized array params, #2410) -- and skips
cleanly when iverilog or the binary is absent.

Negative control done twice: the first attempt was a no-op edit that
silently "passed", which is exactly the failure this repo keeps
rediscovering. Lowering one module's baseline by 3 now prints
"WORSE memory: 3 -> 6" and exits 1; restoring returns 0.

Refs #2325.
@gHashTag
gHashTag enabled auto-merge (squash) August 22, 2026 14:49
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-22 14:51:08 UTC

Summary

Status Count
Total Open PRs 5
PRs with Failing Checks 2
PRs with All Checks Green 3
READY 3
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=42d2b54210da != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant