Repository navigation
feat(ci): elaboration errors may fall, never rise - #2430
Merged
Merged
Conversation
Three emitter classes took the 32-module fpga set from 573 iverilog elaboration errors to 186 in one evening, and nothing held that line: the conformance job executes two modules and the other thirty are only yosys-linted, which is how the class grew unseen in the first place. check_elab_ratchet.py records the count per module and fails when any module gains errors, naming the module and both numbers. It does not demand zero -- the remainder is two named design decisions (string comparison in hardware; unsized array params, #2410) -- and skips cleanly when iverilog or the binary is absent. Negative control done twice: the first attempt was a no-op edit that silently "passed", which is exactly the failure this repo keeps rediscovering. Lowering one module's baseline by 3 now prints "WORSE memory: 3 -> 6" and exits 1; restoring returns 0. Refs #2325.
gHashTag
enabled auto-merge (squash)
August 22, 2026 14:49
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 14:51:08 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2325. Holds the 573 -> 186 win per module; fails naming the module and both numbers. Negative control done twice — the first was a no-op that silently passed.
🤖 Generated with Claude Code